Repository navigation
fix(desktop): cap share popover port list height and scroll - #9533
Conversation
A workspace with many detected ports made the Share popover grow past the window. The list now stops at 240px (about 8 rows) and scrolls.
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Notes
Testing
bunx biome checkon the changed fileSummary by cubic
Caps the "Ports on this computer" list in the Share workspace popover at 240px (about 8 rows) and makes it scroll inside itself. Before, a workspace with many detected ports made the popover grow past the window.
Uses a max height rather than a fixed one, so a short list doesn't leave empty space under it. The header, invite box, and access sections stay where they are.
Written for commit a86bb4a. Summary will update on new commits.
Summary by CodeRabbit