Skip to content

fix(desktop): cap share popover port list height and scroll - #9533

Merged
harshithmullapudi merged 1 commit into
mainfrom
superset/cloud-workspace-d02059d5
Nov 9, 2026
Merged

harshithmullapudi merged 1 commit into
mainfrom
superset/cloud-workspace-d02059d5

Conversation

@harshithmullapudi

@harshithmullapudi harshithmullapudi commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The "Ports on this computer" list in the Share workspace popover now stops at 240px (about 8 rows) and scrolls inside itself. Before, a workspace with many detected ports (for example, around 23 workerd/electron/MainThread ports) made the popover grow past the window.

Notes

  • This sets a max height, not a fixed height, so a short list doesn't leave empty space under it. The header, invite box and access sections stay where they are.

Testing

  • bunx biome check on the changed file
  • Not checked in the running app

Summary by cubic

Caps the "Ports on this computer" list in the Share workspace popover at 240px (about 8 rows) and makes it scroll inside itself. Before, a workspace with many detected ports made the popover grow past the window.

Uses a max height rather than a fixed one, so a short list doesn't leave empty space under it. The header, invite box, and access sections stay where they are.

Written for commit a86bb4a. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Style
    • Long port lists now scroll within a height-limited container.

A workspace with many detected ports made the Share popover grow past the
window. The list now stops at 240px (about 8 rows) and scrolls.
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The share port list now has a maximum height of max-h-60 and scrolls vertically when its contents overflow.

Changes: Share port list layout

Layer / File(s) Summary
Constrain and scroll the port list
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/CloudWorkspaceShareButton/components/SharePortsSection/SharePortsSection.tsx
The port list container now has a maximum height and vertical overflow scrolling.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • ParadevAI/Paradev#9493: Adds the SharePortsSection.tsx component whose port list layout this change updates.

Suggested reviewers: superset-home

Merge Risk: Minimal · up to a86bb

The change bounds long port lists without adding space to short lists. No merge-blocking regression is established; short-window overflow remains a pre-existing limitation.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@harshithmullapudi
harshithmullapudi merged commit 9bcec9d into main Nov 9, 2026
16 of 18 checks passed

This branch was previously deployed

1 inactive deployment
preview — a86bb4a3 Deployed Nov 9, 2026 by harshithmullapudi via Deploy Docs #14185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants